Skip to content

Fix Tests for v5.33 release #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Fix Tests for v5.33 release #567

merged 2 commits into from
Jun 30, 2025

Conversation

@zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Jun 30, 2025 •
edited
Loading

Description

  • Add 503 to the retry_statuses because kubeconfig unavailable is now a 503 error.
  • Remove error message assertion because one error message has been modified, and they may also be updated again in the future.

Testing

pytest test/integration/models/lke/test_lke.py -k test_get_and_delete_kubeconfig

pytest test/integration/models/vpc/test_vpc.py -k test_fails_create_subnet_invalid_data

@zliang-akamai zliang-akamai requested a review from a team as a code owner June 30, 2025 15:35
@zliang-akamai zliang-akamai requested review from ezilber-akamai and jriddle-linode and removed request for a team June 30, 2025 15:35
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Jun 30, 2025
jriddle-linode
jriddle-linode approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ykim-akamai
ykim-akamai reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these

@zliang-akamai zliang-akamai added ignore-for-release PRs you do not want to render in the changelog and removed testing for updates to the testing suite in the changelog. labels Jun 30, 2025
@zliang-akamai zliang-akamai merged commit 389905e into linode:dev Jun 30, 2025
12 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/fix-test-063025 branch June 30, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

@ezilber-akamai ezilber-akamai Awaiting requested review from ezilber-akamai ezilber-akamai is a code owner automatically assigned from linode/dx

Assignees

No one assigned

Labels

ignore-for-release PRs you do not want to render in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zliang-akamai @jriddle-linode @ykim-akamai