-
Notifications
You must be signed in to change notification settings - Fork 5
Update README #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #89
Conversation
f9aeac2 to
7109d86
Compare
msirringhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and nits.
BUILDING.md
Outdated
|
|
||
| # For Installing/Testing | ||
|
|
||
| If you are interested in installing the program, you can use `meson install` to install the details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention here that it is not necessary to install it to test it (see "Running the server"-instructions). Many contributors/testers/users will probably like to first run it in a 'throw away' fashion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wanted to keep it simple for testers because there's a bunch of editing and manual file pl. But I can add a statement pointing to the instructions below.
| If you are interested in installing the program, you can use `meson install` to install the details. | |
| If you are interested in installing the program, you can use `meson install` to install the details. (If you would like to test without installing, you can | |
| follow the [build instructions for development](#for-development) below.) |
GOALS.md
Outdated
| @@ -0,0 +1,55 @@ | |||
| # Goals | |||
|
|
|||
| The goal of this repository is to define a spec for clients (apps, browsers, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we provide more than 'just' a spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, reworded this one a bit.
GOALS.md
Outdated
|
|
||
| The goal of this repository is to define a spec for clients (apps, browsers, | ||
| etc.) to retrieve user credentials in a uniform way across Linux desktop | ||
| environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention the other OS-level services of Windows, Mac and Android for comparison here, for people familiar with these services?
We could also mention for more clarity that currently on Linux, every app (e.g. browsers) that wants to support FIDO, etc. has to implement these things on their own, instead of "asking the OS for it", as is done on other OS's, which this project tries to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I added a "Motivation" section before describing the goals.
msirringhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
credentialsd.BUILDING.md, reference build instructions inREADME.mdandwebext/README.mdCloses #85.