Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Jun 16, 2025

Update changelog and .README.html for version 1.4.0

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Prepare release 1.4.0 by adding container build support, resolving Ansible 2.19 issues, overhauling CI and tests, and refreshing documentation.

New Features:

  • Support running the role in container builds.

Bug Fixes:

  • Fix compatibility with Ansible 2.19.

CI:

  • Disable ansible-plugin-scan; bump ansible-lint to v25; integrate codespell; upgrade tox-lsr and testing-farm actions; enhance and customize qemu and container build test plans.

Documentation:

  • Update HTML documentation to reflect container build option limitations, correct CSS styles and typos, and refine server tuning details.

Tests:

  • Add bootc end-to-end validation test and corresponding CI support.

Update changelog and .README.html for version 1.4.0

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner June 16, 2025 22:20
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 16, 2025

Reviewer's Guide

This PR updates the project to version 1.4.0 by adding a structured changelog entry and refines the HTML documentation with styling tweaks, typo corrections, and new notes on container-build behavior.

File-Level Changes

Change Details Files
Add version 1.4.0 changelog entry CHANGELOG.md
Refine HTML styling and correct typo in README
  • Add -webkit-text-size-adjust rule
  • Adjust sourceCode span display and print styling
  • Fix “server-tunning” typo to “server-tuning” in TOC and header
.README.html
Enhance README documentation with container build notes
  • Add notice that postgresql_password is unavailable in container builds
  • Add notice that postgresql_input_file is unavailable in container builds
  • Clarify postgresql_server_tuning defaults when using a Buildah connection
.README.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes - here's some feedback:

  • The repeated “This option is not available for running the role in container builds.” paragraphs could be consolidated into a shared note to reduce duplication.
  • Please verify that the CSS adjustments to pre > code.sourceCode spans don’t adversely affect code snippet rendering across supported browsers and print layouts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The repeated “This option is not available for running the role in container builds.” paragraphs could be consolidated into a shared note to reduce duplication.
- Please verify that the CSS adjustments to pre > code.sourceCode spans don’t adversely affect code snippet rendering across supported browsers and print layouts.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit fa321cc into linux-system-roles:main Jun 16, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant