Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Sep 20, 2025

ensure all facts/vars are defined for testing

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

  • Include the postgresql role’s set_vars.yml in install_and_check test to populate all required facts and variables when __run_role is false

@richm richm requested a review from spetrosi as a code owner September 20, 2025 00:19
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a dedicated task in the install_and_check test playbook to run the postgresql role in a vars-only mode, ensuring all necessary facts and variables are initialized during testing.

File-Level Changes

Change Details Files
Ensure test facts and variables are defined by including postgresql role vars-only task
  • Added a ‘Run postgresql role to set vars only’ include_role task
  • Set tasks_from to set_vars.yml for vars initialization
  • Applied when condition to run only if __run_role is false
tests/tasks/install_and_check.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ensure all facts/vars are defined for testing

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
Copy link
Contributor Author

richm commented Sep 20, 2025

[citest]

@richm richm merged commit 5dfb063 into linux-system-roles:main Sep 20, 2025
27 checks passed
@richm richm deleted the fix-bootc-e2e branch September 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant