Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Sep 20, 2025

On some versions of ansible/jinja, the YAML format does not work, so use
the JSON format to pass in __bootc_validation

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Use JSON format for the __bootc_validation environment variable in the qemu-kvm integration tests GitHub Actions workflow to avoid YAML parsing issues.

Bug Fixes:

  • Fix __bootc_validation argument parsing in some Ansible/Jinja versions by switching to JSON format

CI:

  • Switch __bootc_validation declaration to JSON in the qemu-kvm integration tests workflow

On some versions of ansible/jinja, the YAML format does not work, so use
the JSON format to pass in __bootc_validation

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner September 20, 2025 00:19
@richm richm self-assigned this Sep 20, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switch the QEMU KVM integration test workflow to pass the __bootc_validation extra var as a JSON-formatted string instead of YAML to ensure compatibility with all Ansible/Jinja versions.

File-Level Changes

Change Details Files
Use JSON format for __bootc_validation in CI workflow
  • Replaced YAML-style -e "__bootc_validation: true" with JSON string -e '{"__bootc_validation": true}'
  • Adjusted the CI job command to embed the validation flag in JSON
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 9a5ac73 into main Sep 20, 2025
25 checks passed
@richm richm deleted the use-json-format branch September 20, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant