-
Notifications
You must be signed in to change notification settings - Fork 18
Feature test retry #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed bug with keep job entry in case of pause Signed-off-by: Ilya <rihter007@inbox.ru>
Signed-off-by: Ilya <rihter007@inbox.ru>
Filter target events by latest test retry Signed-off-by: Ilya <rihter007@inbox.ru>
c658e7b
to
7278581
Compare
Will add e2e test for test retry |
Signed-off-by: Ilya <rihter007@inbox.ru>
85e9fbb
to
8b00a0e
Compare
Added unit tests |
The majority of changes are tests, I can split PR into two to ease the reviewing |
c5c64e5
to
a1298ca
Compare
Signed-off-by: Ilya <rihter007@inbox.ru>
a1298ca
to
f9a69b9
Compare
dcf4907
to
b8fc781
Compare
Signed-off-by: Ilya <rihter007@inbox.ru>
b8fc781
to
7826057
Compare
Ha-ha, need to fix race condition in test runner. Unit test fails, because it contains light-weight step |
65e493e
to
725c9c3
Compare
Signed-off-by: Ilya <rihter007@inbox.ru>
725c9c3
to
9971ce7
Compare
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage ? 66.27%
=======================================
Files ? 155
Lines ? 9263
Branches ? 0
=======================================
Hits ? 6139
Misses ? 2473
Partials ? 651
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
i added a couple more comments on your answers. I see a button above with "requested review" though. Can you confirm that a new iteration is ready? |
I'll wait for the tests fix though |
Signed-off-by: Ilya <rihter007@inbox.ru>
Done :) |
Code-style improvements Signed-off-by: Ilya <rihter007@inbox.ru>
b462943
to
05135e3
Compare
Initial implementation of test retry (similar to previous implementation of step retry).
Test retry is useful when target became broken and we should re-launch test from the beginning.
Next PR: add test retry to database.