Skip to content

Conversation

rihter007
Copy link
Contributor

Initial implementation of test retry (similar to previous implementation of step retry).
Test retry is useful when target became broken and we should re-launch test from the beginning.

Next PR: add test retry to database.

Fixed bug with keep job entry in case of pause

Signed-off-by: Ilya <rihter007@inbox.ru>
Signed-off-by: Ilya <rihter007@inbox.ru>
Filter target events by latest test retry

Signed-off-by: Ilya <rihter007@inbox.ru>
@rihter007
Copy link
Contributor Author

Will add e2e test for test retry

Signed-off-by: Ilya <rihter007@inbox.ru>
@rihter007
Copy link
Contributor Author

Added unit tests

@rihter007
Copy link
Contributor Author

The majority of changes are tests, I can split PR into two to ease the reviewing

Signed-off-by: Ilya <rihter007@inbox.ru>
Signed-off-by: Ilya <rihter007@inbox.ru>
@rihter007
Copy link
Contributor Author

Ha-ha, need to fix race condition in test runner. Unit test fails, because it contains light-weight step

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@41fe5ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage        ?   66.27%           
=======================================
  Files           ?      155           
  Lines           ?     9263           
  Branches        ?        0           
=======================================
  Hits            ?     6139           
  Misses          ?     2473           
  Partials        ?      651           
Flag Coverage Δ
e2e 50.29% <0.00%> (?)
integration 57.45% <0.00%> (?)
unittests 47.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fe5ac...05135e3. Read the comment docs.

@mimir-d
Copy link
Member

mimir-d commented Nov 16, 2021

i added a couple more comments on your answers. I see a button above with "requested review" though. Can you confirm that a new iteration is ready?

@mimir-d
Copy link
Member

mimir-d commented Nov 16, 2021

I'll wait for the tests fix though

Signed-off-by: Ilya <rihter007@inbox.ru>
@rihter007
Copy link
Contributor Author

I'll wait for the tests fix though

Done :)

Code-style improvements

Signed-off-by: Ilya <rihter007@inbox.ru>
@rihter007 rihter007 merged commit 73a2f48 into main Nov 18, 2021
@rihter007 rihter007 deleted the feature_test_retry branch November 18, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants