Update u-root build support with 'uroot-source' #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified with u-root upstream commit 504ed8127, u-root initramfs can be built. Without this would see build error. To get the old behavior check out commit 8b790de for your u-root. For more detail please see https://github.com/u-root/u-root Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
Contributor
Author
|
This is necessary for the current u-root tip. |
|
Why do we need to build u-root in source mode? |
Contributor
Author
It's not source mode, it's a new flag introduced recently. "For those to still work we added a new flag called -uroot-source which expects the filesystem path of a local copy of the u-root repository. " from the newest u-root Readme. |
Contributor
Author
|
Hi @rminnich , Jonathan and I don't have merge permission could you help? |
Contributor
Author
|
cd examples/qemu; make and verified the image can be built and boot up u-root shell. |
rminnich
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.