-
Notifications
You must be signed in to change notification settings - Fork 40
fix: improve vtable ownership verification in hasVtable #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin-ci-robot
added a commit
to linuxdeepin/qt6platform-plugins
that referenced
this pull request
Oct 16, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#305
deepin-ci-robot
added a commit
to linuxdeepin/qt6platform-plugins
that referenced
this pull request
Oct 16, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#305
ComixHe
requested changes
Oct 16, 2025
1. Enhanced hasVtable function to verify vtable pointer matches recorded ghost vtable 2. Added address reuse detection with detailed warning logging 3. Implemented cleanup of stale mappings when address reuse is detected 4. Fixed potential false positives when memory addresses are reused by different objects Log: Fixed vtable hook detection reliability when memory addresses are reused Influence: 1. Test vtable hooking with objects that have similar memory addresses 2. Verify hasVtable returns correct results after object destruction and recreation 3. Test memory reuse scenarios with multiple object allocations 4. Check warning logs for address reuse detection 5. Verify no memory leaks when stale mappings are cleaned up 6. Test vtable hook stability in long-running applications fix: 改进 hasVtable 函数中的虚表所有权验证 1. 增强 hasVtable 函数以验证虚表指针是否与记录的 ghost 虚表匹配 2. 添加地址重用检测和详细的警告日志记录 3. 在检测到地址重用时实现陈旧映射的清理 4. 修复当内存地址被不同对象重用时可能出现的误判问题 Log: 修复了内存地址被重用时虚表钩子检测的可靠性问题 Influence: 1. 测试具有相似内存地址的对象的虚表钩子功能 2. 验证对象销毁和重新创建后 hasVtable 返回正确结果 3. 测试多个对象分配时的内存重用场景 4. 检查地址重用检测的警告日志 5. 验证清理陈旧映射时没有内存泄漏 6. 测试长时间运行应用程序中虚表钩子的稳定性 PMS: BUG-329331 BUG-334591
deepin-ci-robot
added a commit
to linuxdeepin/qt6platform-plugins
that referenced
this pull request
Oct 16, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#305
Contributor
deepin pr auto review我来审查这段代码的改进。 语法逻辑
代码质量
代码性能
代码安全
改进建议
总体而言,这是一个很好的改进,显著提高了代码的可靠性和安全性。 |
ComixHe
approved these changes
Oct 16, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, ComixHe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/qt6platform-plugins
that referenced
this pull request
Oct 16, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#305
18202781743
added a commit
to 18202781743/dtkcore
that referenced
this pull request
Oct 16, 2025
18202781743
added a commit
to linuxdeepin/dtkcore
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghost vtable
different objects
Log: Fixed vtable hook detection reliability when memory addresses are
reused
Influence:
and recreation
fix: 改进 hasVtable 函数中的虚表所有权验证
Log: 修复了内存地址被重用时虚表钩子检测的可靠性问题
Influence:
PMS: BUG-329331 BUG-334591