Skip to content

Conversation

@nemchik
Copy link
Member

@nemchik nemchik commented Jul 30, 2023

Base image changes:

  • add packages needed for cron to be available
    • Debian/Ubuntu don't have the option to use crond from busybox (it is not included) so they install cron through apt.
    • Alpine already includes busybox with crond.
    • Arch and Fedora will install busybox to provide crond.
  • if /defaults/crontabs/abc or /defaults/crontabs/root exist (in the downstream image) setup /config/crontabs/ for the user and import user crontabs to system
    • downstream images should only ship abc crontab unless absolutely necessary (ex: rsnapshot needs root, cron mod sets up both so the user can do whatever they want)
  • if crontabs have been setup on system, run the cron service, otherwise sleep infinity (do nothing)

These should be safe to merge anytime as they don't actually do anything unless the downstream image (or the cron mod) include crontabs, or technically the user can mount /etc/crontabs/abc or /etc/crontabs/root to their image, but we should only ever ship /defaults/crontabs/* in downstream images so we're consistent in setting up the /config/crontabs/*

Signed-off-by: Eric Nemchik <eric@nemchik.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-b53571add9f420b356330035d8ab1539d8ab0187-pr-3/index.html
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-b53571add9f420b356330035d8ab1539d8ab0187-pr-3/shellcheck-result.xml

Tag Passed
amd64-bookworm-5968bc6d-pkg-5968bc6d-dev-b53571add9f420b356330035d8ab1539d8ab0187-pr-3
arm64v8-bookworm-5968bc6d-pkg-5968bc6d-dev-b53571add9f420b356330035d8ab1539d8ab0187-pr-3

nemchik added 2 commits July 30, 2023 09:48
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-e1965900b898abe0e830f352461faee31a39fee7-pr-3/index.html
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-e1965900b898abe0e830f352461faee31a39fee7-pr-3/shellcheck-result.xml

Tag Passed
amd64-bookworm-5968bc6d-pkg-5968bc6d-dev-e1965900b898abe0e830f352461faee31a39fee7-pr-3
arm64v8-bookworm-5968bc6d-pkg-5968bc6d-dev-e1965900b898abe0e830f352461faee31a39fee7-pr-3

@nemchik nemchik marked this pull request as ready for review August 1, 2023 18:29
@nemchik nemchik requested a review from a team August 1, 2023 18:33
@nemchik nemchik marked this pull request as draft August 2, 2023 02:22
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-d388077bc38dc6ab5ac2ed24412f56e3ffef3ed4-pr-3/index.html
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-5968bc6d-pkg-5968bc6d-dev-d388077bc38dc6ab5ac2ed24412f56e3ffef3ed4-pr-3/shellcheck-result.xml

Tag Passed
amd64-bookworm-5968bc6d-pkg-5968bc6d-dev-d388077bc38dc6ab5ac2ed24412f56e3ffef3ed4-pr-3
arm64v8-bookworm-5968bc6d-pkg-5968bc6d-dev-d388077bc38dc6ab5ac2ed24412f56e3ffef3ed4-pr-3

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@nemchik nemchik added awaiting-approval Stale exempt and removed no-pr-activity labels Sep 22, 2023
@nemchik nemchik marked this pull request as ready for review November 1, 2023 22:44
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-c89bb68d-pkg-c89bb68d-dev-2ac7efe066ccdb5f9520b475d08ef2ae4666c6c0-pr-3/index.html
https://ci-tests.linuxserver.io/lspipepr/debian/bookworm-c89bb68d-pkg-c89bb68d-dev-2ac7efe066ccdb5f9520b475d08ef2ae4666c6c0-pr-3/shellcheck-result.xml

Tag Passed
amd64-bookworm-c89bb68d-pkg-c89bb68d-dev-2ac7efe066ccdb5f9520b475d08ef2ae4666c6c0-pr-3
arm64v8-bookworm-c89bb68d-pkg-c89bb68d-dev-2ac7efe066ccdb5f9520b475d08ef2ae4666c6c0-pr-3

@nemchik nemchik merged commit ad59e45 into master Nov 2, 2023
@nemchik nemchik deleted the standard-cron branch November 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Stale exempt

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants