Skip to content

Conversation

@huncrys
Copy link
Contributor

@huncrys huncrys commented Jul 13, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Added required inotify-tools to dependencies, and required files to make autoreload work, same as in SWAG.

Benefits of this PR and context:

Closes #112

How Has This Been Tested?

docker build -t nginxtest .
docker run -e NGINX_AUTORELOAD=true -d --rm --name lsionginxtest nginxtest
docker exec lsionginxtest touch /config/nginx/test.conf

Inspected docker logs lsionginxtest afterwards:

/config/nginx/ CREATE test.conf
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful
Changes to nginx config detected and the changes are valid, reloading nginx

Source / References:

#110
linuxserver/docker-swag@02ed03a

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nginx/1.28.0-r3-pkg-7f7c2c87-dev-c2c2f547d3c5f2d89a5311540501363f924cf82a-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/nginx/1.28.0-r3-pkg-7f7c2c87-dev-c2c2f547d3c5f2d89a5311540501363f924cf82a-pr-113/shellcheck-result.xml

Tag Passed
amd64-1.28.0-r3-pkg-7f7c2c87-dev-c2c2f547d3c5f2d89a5311540501363f924cf82a-pr-113
arm64v8-1.28.0-r3-pkg-7f7c2c87-dev-c2c2f547d3c5f2d89a5311540501363f924cf82a-pr-113

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nginx/1.28.0-r3-pkg-7f7c2c87-dev-1dece5b009678a0a537d1350c412469be60a7402-pr-113/index.html
https://ci-tests.linuxserver.io/lspipepr/nginx/1.28.0-r3-pkg-7f7c2c87-dev-1dece5b009678a0a537d1350c412469be60a7402-pr-113/shellcheck-result.xml

Tag Passed
amd64-1.28.0-r3-pkg-7f7c2c87-dev-1dece5b009678a0a537d1350c412469be60a7402-pr-113
arm64v8-1.28.0-r3-pkg-7f7c2c87-dev-1dece5b009678a0a537d1350c412469be60a7402-pr-113

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, stupid oversight on my part not to have included them.

@github-project-automation github-project-automation bot moved this from PRs to PRs Approved in Issue & PR Tracker Jul 13, 2025
@thespad thespad merged commit bc7db07 into linuxserver:master Jul 13, 2025
2 checks passed
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[BUG] Auto reload functionality does not work

3 participants