-
Notifications
You must be signed in to change notification settings - Fork 32
feat(tests): Check for specific error messages in test suite #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implements liquid-java#105. The `TestExamples.java` test suite will now read a `// @expectederror: "Error Title"` comment from any "Error" file and fail the test if the error title does not match.
Update groupId (liquid-java#106)
|
Hi @subha0319! Thanks for contributing! Can you add a couple of examples with those annotations to see if it is working? We can also decide to have those annotation lines as the first line in the file, so that it is easier to check it and faster to run the tests |
Implements liquid-java#105. The `TestExamples.java` test suite will now read a `// @expectederror: "Error Title"` comment from any "Error" file and fail the test if the error title does not match.
|
Hi @CatarinaGamboa, Thanks for the feedback. I've added the And I've made sure to place the annotations on line 1 in all the examples. Let me know if there's anything else. |
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, we can change the getExpectedError to be more eddicient
liquidjava-verifier/src/test/java/liquidjava/api/tests/TestExamples.java
Outdated
Show resolved
Hide resolved
liquidjava-verifier/src/test/java/liquidjava/api/tests/TestExamples.java
Outdated
Show resolved
Hide resolved
|
Hi @CatarinaGamboa, Thanks for the great review! I've updated the PR with all your suggestions:
Let me know if there's anything else! |
Implements #105.
Updates the
TestExamplestest suite to check for specific error messages.The test harness now reads a comment tag
// @ExpectedError: "Error Title"from files that are expected to fail and validates the actual error title against the expected one.