Skip to content

Assafmilman fix double resolvers bug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Assafmilman fix double resolvers bug #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abce05c
not going recursive on mutation type, to avoid dobule resolve on fields
assafmilman Nov 21, 2017
a3d98cd
fixed position of args
assafmilman Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ function resolveMiddlewareWrapper(resolve = defaultResolveFn, directives = {}) {
* Scanning the shema and wrapping the resolve of each field with the support
* of the graphql custom directives resolve execution
*/
function wrapFieldsWithMiddleware(type, typeMet = {}) {
function wrapFieldsWithMiddleware(type, deepWrap = true, typeMet = {}) {
if(!type){
return;
}
Expand All @@ -106,10 +106,10 @@ function wrapFieldsWithMiddleware(type, typeMet = {}) {
if (field && !typeMet[field.type.name]) {
if (!!field && typeof field == 'object') {
field.resolve = resolveMiddlewareWrapper(field.resolve, field.directives);
if (field.type._fields) {
wrapFieldsWithMiddleware(field.type, typeMet)
} else if (field.type.ofType && field.type.ofType._fields) {
wrapFieldsWithMiddleware(field.type.ofType, typeMet);
if (field.type._fields && deepWrap) {
wrapFieldsWithMiddleware(field.type, deepWrap, typeMet)
} else if (field.type.ofType && field.type.ofType._fields && deepWrap) {
wrapFieldsWithMiddleware(field.type.ofType, deepWrap, typeMet);
}
}
}
Expand Down Expand Up @@ -140,7 +140,7 @@ exports.applySchemaCustomDirectives = function (schema) {
}

wrapFieldsWithMiddleware(schema._queryType);
wrapFieldsWithMiddleware(schema._mutationType);
wrapFieldsWithMiddleware(schema._mutationType, false);

return true;
};