Skip to content

Conversation

kimown
Copy link
Contributor

@kimown kimown commented Feb 23, 2017

fix: #54

@kimown kimown changed the title Update db mysql db init check dbpassword Feb 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.604% when pulling 63d2f44 on kimown:patch-1 into 3c069ed on lisong:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 79.604% when pulling 63d2f44 on kimown:patch-1 into 3c069ed on lisong:master.

@kimown
Copy link
Contributor Author

kimown commented Feb 23, 2017

@lisong ok 好的

@lisong
Copy link
Owner

lisong commented Feb 23, 2017

if (_.isString(argv.dbpassword) || _.isNumber(argv.dbpassword)) {
    dbpassword = _.toString(argv.dbpassword);
}

改成这样应该好些

fix: not use default password
@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 79.604% when pulling bb9fda0 on kimown:patch-1 into 3c069ed on lisong:master.

@kimown
Copy link
Contributor Author

kimown commented Feb 23, 2017

这也可以,但是已经使用yargs库来解析cli参数,这样做相比简单一些 。

@lisong
Copy link
Owner

lisong commented Feb 23, 2017

如果yargs有这样的功能,那可以去掉

if (_.isString(argv.dbpassword) || _.isNumber(argv.dbpassword)) {
    dbpassword = _.toString(argv.dbpassword);
}

这个判断

@lisong
Copy link
Owner

lisong commented Feb 23, 2017

upgrade 这个命令是否也需要配置这种配置?

fix: same as upgrade command
@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 79.604% when pulling 40949cc on kimown:patch-1 into 3c069ed on lisong:master.

@lisong
Copy link
Owner

lisong commented Feb 23, 2017

3q

@lisong lisong merged commit 6175ee7 into lisong:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: If encoding is specified then the first argument must be a string

3 participants