feat: migration convenience methods to config classes #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add migrate_up/down, get_current_migration, create_migration, init_migrations methods - Add stamp_migration and fix_migrations methods - Implement proper type narrowing across all 4 config base classes - Sync methods return None, async methods return Awaitable[None] - Full backward compatibility with existing migration commands - All existing tests pass without modification
- NoPoolSyncConfig.migrate_up was incorrectly wrapped with await_() - Sync methods should call sync command methods directly - All linting issues resolved - All 54 tests still passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new migration methods to database configuration classes, simplifying the migration process by allowing direct calls on config instances.