feat: add disable_di flag to disable built in framework DI
#222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask extensions. When enabled, disables built-in dependency injection to allow users to manage database lifecycle with their own DI solutions (e.g., Dishka).
Adds `disable_di` boolean flag to Litestar, Starlette/FastAPI, and Flask extensions. When enabled, disables built-in dependency injection to allow users to manage database lifecycle with their own DI solutions (e.g., Dishka). ## Changes ### Configuration - Added `disable_di: NotRequired[bool]` to FlaskConfig, LitestarConfig, and StarletteConfig TypedDicts in sqlspec/config.py - Default: False (backward compatible) ### Framework Extensions - **Litestar**: Conditionally skip DI provider registration when disable_di=True - **Starlette/FastAPI**: Conditionally skip middleware when disable_di=True - **Flask**: Conditionally skip request hooks when disable_di=True ### Test Organization - Reorganized extension integration tests into subdirectories: - tests/integration/test_extensions/test_flask/ - tests/integration/test_extensions/test_starlette/ - tests/integration/test_extensions/test_fastapi/ - tests/integration/test_extensions/test_litestar/ - Added comprehensive disable_di tests for all three frameworks - Verified backward compatibility with default behavior tests ## Testing - All extension unit tests pass (104 passed, 1 skipped) - All extension integration tests pass (37 passed, 1 skipped) - Type checking clean (mypy + pyright: 0 errors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
disable_diboolean flag to Litestar, Starlette/FastAPI, and Flaskextensions. When enabled, disables built-in dependency injection to allow
users to manage database lifecycle with their own DI solutions (e.g., Dishka).