fix(litestar): correctly handle sync context manager #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the Litestar SQLSpecPlugin connection provider unwraps sync context managers before injecting connections.
Closes #238
The Problem
provide_connection()connection_provider_maker()treated any non-async context managers as ready-to-use connections, so Litestar stored_GeneratorContextManagerobjects.AttributeError: '_GeneratorContextManager' object has no attribute 'cursor'when the driver tried to call.cursor().The Solution
with_ensure_async_()so the provider always awaits the context manager path and stores the actual connection.SqliteConfigto ensure sync context managers yield proper driver connections and clean up scope state.Key Features
connection_provider_maker().