fix(observability): explicitly initialize LifecycleDispatcher guard attributes #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
AttributeError: 'LifecycleDispatcher' object has no attribute 'has_pool_create'when SQLSpec is installed with mypyc compilation enabled.The Problem
LifecycleDispatcherused dynamic__slots__with tuple unpacking (*GUARD_ATTRS)getattr()calls on dynamically created slot attributes failedHATCH_BUILD_HOOKS_ENABLE=1The Solution
Explicitly define and initialize all guard attributes:
Key Features
__slots__(no tuple unpacking)Falsebefore dynamic assignmentTesting
test_lifecycle_dispatcher_guard_attributes_always_accessible()