Skip to content

Conversation

@paulo-valim
Copy link
Collaborator

@paulo-valim paulo-valim commented May 8, 2024

Screenshot 2024-05-08 at 08 33 11

Front-end improvements / fixes

Other tasks before publishing

  • Add video to the hero section (and change the image/thumbnail, and copy on hover)
  • Add video to the "Read data from structured data file formats" section (and change the copy on hover)
  • Try to reduce font-size of the whole page to match font-size of the Livebook home page

@paulo-valim paulo-valim changed the title WIP [WIP] New livebook Teams LP May 8, 2024
@netlify
Copy link

netlify bot commented May 8, 2024

Deploy Preview for livebook-dev ready!

Name Link
🔨 Latest commit aa8afbf
🔍 Latest deploy log https://app.netlify.com/sites/livebook-dev/deploys/66acec5b0502b800080167df
😎 Deploy Preview https://deploy-preview-100--livebook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

paulo-valim and others added 5 commits May 13, 2024 13:41
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
@paulo-valim paulo-valim marked this pull request as ready for review May 17, 2024 18:11
@paulo-valim paulo-valim changed the title [WIP] New livebook Teams LP New livebook Teams LP May 17, 2024
@hugobarauna
Copy link
Member

@paulo-valim found a UI bug where the title "What can you build with
Livebook Teams?" goes behind the video when resizing the window:

CleanShot 2024-05-21 at 16 06 01

Here's a video showing the bug: https://share.cleanshot.com/q9PLrLM4

@hugobarauna
Copy link
Member

@paulo-valim we need to review/change the resolution of the images.

For example, this is a screenshot (in my MacBook screen) of the beginning of the "Build with Elixir" section:

CleanShot 2024-05-21 at 16 32 59@2x

Look at the resolution of the images, they don't feel sharp.

Now look at the screenshot of that part inside Figma:

CleanShot 2024-05-21 at 16 33 31@2x

The images feel sharp.

Please review the images (maybe need to export them again from Figma).

Also, after exporting the image, reduce the file size using a tool like this: https://tinypng.com/ (that's the one I use manually).

@hugobarauna
Copy link
Member

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

@paulo-valim
Copy link
Collaborator Author

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

@hugobarauna, I was checking how to do that, and the fix will depend on the video player we use. Will it be on YT, or do you plan to use another player?

@hugobarauna
Copy link
Member

@paulo-valim found another improvement task.

  • when the visitor clicks the play button of a video (either the main one or the one in the bottom)
  • and the visitors starts to play the video
  • after the visitor closes the modal
  • the video continues to be played in the background
  • but the video should stop playing

Here's a video showing the problem: https://share.cleanshot.com/NK0ysb22

@hugobarauna, I was checking how to do that, and the fix will depend on the video player we use. Will it be on YT, or do you plan to use another player?

@paulo-valim we’ll use youtube. 👍🏻

@hugobarauna
Copy link
Member

@josevalim just added the video about deploying with teams.

I think this is ready to be merged and deployed.

Should we move forward?

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go to me!

We don't have a teams privacy policy yet
@hugobarauna hugobarauna merged commit 2ff986b into livebook-dev:main Aug 2, 2024
@hugobarauna hugobarauna deleted the teams-lp branch August 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants