This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21093 ]] Handle thrown errors #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that thrown errors which do not have a line in the `scriptExecutionErrors` do not cause an execution error when looking up the description.
This patch ensures that descriptions of thrown errors in the script editor include the line number they were thrown on.
Member
|
I think this should maybe go into develop-8.0, if it's trivial to apply there |
Member
|
Or at least release-9.0.0, for its current milestone |
Member
Author
|
Sorry... forgot to set the target branch. It's not an issue in 8.1 as far as I could see. |
Member
|
@livecode-vulcan review ok 5372a95 |
|
💙 review by @livecodeali ok 5372a95 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that thrown errors which do not have a line in the
scriptExecutionErrorsdo not cause an execution error when looking upthe description.
Additionally include line in thrown error description this patch ensures that descriptions of thrown errors in the script editor include the line number they were thrown on.