Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@livecodepanos
Copy link
Contributor

No description provided.

@livecodepanos livecodepanos added this to the 9.0.1-rc-1 milestone Apr 9, 2018
@livecodepanos livecodepanos changed the title [Bug 21174] Ensure "Sample Stacks" do show up in menu "Windows" [Bug 21174] Ensure "Sample Stacks" stack doed show up in menu "Windows" Apr 9, 2018
@livecodepanos livecodepanos changed the title [Bug 21174] Ensure "Sample Stacks" stack doed show up in menu "Windows" [Bug 21174] Ensure "Sample Stacks" stack does show up in menu "Windows" Apr 9, 2018
@livecodeali
Copy link
Member

livecodeali commented Apr 10, 2018

In order to prevent the need for modifying this in two places in the future, I suggest refactoring slightly to have a function

function revIDEStackIsIDEWindow pStackName
   if pStackName begins with revIDEScriptEditorPrefix() or pStackName is "revDictionary" \
      or pStackName is "revResourceCenter" or pStackName is "revOnline" then
      return true
   end if

   return false
end revIDEStackIsIDEWindow

which can then be called from both revIDEStackIsWindow and setupWindowMenu

@livecodeali
Copy link
Member

@livecode-vulcan review ok 75f7b92

@livecode-vulcan
Copy link

💙 review by @livecodeali ok 75f7b92

@livecodepanos livecodepanos merged commit a013f73 into develop-9.0 Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants