This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 18585] Ensure Dictionary traps cmd+A #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livecodeali
reviewed
May 9, 2018
| # bug 17819 enable cmd+c in dictionary | ||
| on commandKeyDown pWhich | ||
| if pWhich is not "C" then | ||
| if pWhich is not "C" and pWhich is not "A" then |
Member
There was a problem hiding this comment.
Could we make this a switch as the logic is quite confusing, and comment the code, something like
switch pWhich
case "A"
-- trap Cmd + A for select all
case "C"
-- trap Cmd + C for copy
break
case "W"
close me
break
default
pass commandKeyDown
end switch
Member
|
@livecode-vulcan review ok fd57957 |
|
💙 review by @livecodeali ok fd57957 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.