Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@livecodepanos
Copy link
Contributor

screen shot 2018-12-31 at 15 36 39

  1. Added new groups for iPhone XR and XSMAX
  2. Modified existing UI to fit all necessary fields.

Binary changes:

In group "Splash Screens":

the ... buttons for splash screen selection have the following code, for iPhone XR and XSMAX, for portrait and landscape respectively:

on mouseUp
   chooseImageFileWithDimension "iPhone XR Portrait splash", "828,1792"
end mouseUp

on mouseUp
   chooseImageFileWithDimension "iPhone XR Landscape splash", "1792,828"
end mouseUp

on mouseUp
   chooseImageFileWithDimension "iPhone XSMAX Portrait splash", "1242,2688"
end mouseUp

on mouseUp
   chooseImageFileWithDimension "iPhone XSMAX Landscape splash", "2688,1242"
end mouseUp

Also changed the tooltips that specify the required dimensions accordingly.

The X buttons for clearing the selected splash screens for iPhone XR and XSMAX (for portrait and landscape respectively) have this code:

on mouseUp
   clearSetting "iPhone XR portrait splash"
end mouseUp

on mouseUp
   clearSetting "iPhone XR landscape splash"
end mouseUp

on mouseUp
   clearSetting "iPhone XSMAX portrait splash"
end mouseUp

on mouseUp
   clearSetting "iPhone XSMAX landscape splash"
end mouseUp

livecode-vulcan added a commit to livecode/livecode that referenced this pull request Jan 9, 2019
[21767] Support for splash images for iPhone XR and XSMAX

Requires livecode/livecode-ide#2024
@montegoulding
Copy link
Member

@livecode-vulcan review ok 70828b6

@livecode-vulcan
Copy link

💙 review by @montegoulding ok 70828b6

@livecodepanos livecodepanos merged commit 08cb1b3 into develop-9.0 Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants