Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@montegoulding
Copy link
Member

This patch fixes the missing font manager factory for emscripten due to a
change in skia. This patch also improves the exclusions of mac and
windows files as they were being included in emscripten also.

This patch fixes the missing font manager factory for emscripten due to a
change in skia. This patch also improves the exclusions of mac and
windows files as they were being included in emscripten also.
@montegoulding montegoulding added this to the 9.0.0-dp-7 milestone May 25, 2017
@runrevmark
Copy link
Contributor

@montegoulding It's not clear from the patch what the issue was exactly - are we including the appropraite FontManager to ensure that emscripten can still render text?

@montegoulding
Copy link
Member Author

The main issue was that is src/ports/SkFontMgr_custom_directory_factory.cpp was being excluded. There is no src/ports/SkFontMgr_linux.cpp any more which is what was being used previously. The custom directory one loads fonts from a directory and because we were defining SK_FONT_FILE_PREFIX I presumed that's what we needed. The only other place that appears is in the android font manager.

@runrevmark
Copy link
Contributor

Got it - thanks :) That at least suggests perhaps fixing the font issue on Android 7 might be done for us by Skia... If it now has a fallback implementation...

@livecode-vulcan review ok 3ec1df6

@livecode-vulcan
Copy link

💙 review by @runrevmark ok 3ec1df6

@runrevmark runrevmark merged commit 80c6f1d into livecode:develop May 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants