Skip to content

Simplify internal events #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2022
Merged

Simplify internal events #100

merged 2 commits into from
Apr 3, 2022

Conversation

@hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Apr 2, 2022

  • Remove redundant internal event
  • Room also directly listens to SignalEvents instead of Engine relaying them.

davidzhao
davidzhao approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@hiroshihorie hiroshihorie merged commit cd4a3f5 into main Apr 3, 2022
@hiroshihorie hiroshihorie deleted the simplify-internal-events branch April 3, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiroshihorie @davidzhao