Simpler APIs #28
Merged
Simpler APIs #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Nov 10, 2021
| return setSourceEnabled(TrackSource.camera, enabled); | ||
| } | ||
|
|
||
| bool isCameraEnabled() { |
Member
There was a problem hiding this comment.
this is better defined on Participant, since it'd make it easier to check for remote participant too.
lib/src/types.dart
Outdated
| unknown, | ||
| camera, | ||
| microphone, | ||
| screenShare, |
Member
There was a problem hiding this comment.
FYI: I also added a ScreenShareAudio type.. for when the screen share is shared with an audio track.
davidliu
approved these changes
Nov 10, 2021
| } | ||
|
|
||
| extension LocalParticipantTrackSourceExt on LocalParticipant { | ||
| Future<void> setCamercaEnabled(bool enabled) async { |
Contributor
There was a problem hiding this comment.
nit: typo in setCamercaEnabled (should be setCameraEnabled)
Member
Author
There was a problem hiding this comment.
Omg yesss thanks onichan!!! 🙏🏻😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.