Skip to content

fix bug for sync tracks. #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix bug for sync tracks. #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/src/core/room.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,12 +439,10 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
var streamId = idParts[1];
var trackSid = event.track.id;

if (kIsWeb && lkBrowser() == BrowserType.firefox) {
// firefox will get streamId (pID|trackId) instead of (pID|streamId) as it doesn't support sync tracks by stream
// and generates its own track id instead of infer from sdp track id.
if (streamId.isNotEmpty && streamId.startsWith('TR')) {
trackSid = streamId;
}
// firefox will get streamId (pID|trackId) instead of (pID|streamId) as it doesn't support sync tracks by stream
// and generates its own track id instead of infer from sdp track id.
if (streamId.isNotEmpty && streamId.startsWith('TR')) {
trackSid = streamId;
}

final participant = _getRemoteParticipantBySid(participantSid);
Expand Down