Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/src/core/room.dart
Original file line number Diff line number Diff line change
Expand Up @@ -636,11 +636,11 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
return null;
}

RemoteParticipant _getOrCreateRemoteParticipant(String identity, lk_models.ParticipantInfo? info) {
Future<RemoteParticipant> _getOrCreateRemoteParticipant(String identity, lk_models.ParticipantInfo? info) async {
RemoteParticipant? participant = _remoteParticipants[identity];
if (participant != null) {
if (info != null) {
participant.updateFromInfo(info);
await participant.updateFromInfo(info);
}
return participant;
}
Expand All @@ -654,7 +654,7 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
name: '',
);
} else {
participant = RemoteParticipant.fromInfo(
participant = await RemoteParticipant.createFromInfo(
room: this,
info: info,
);
Expand Down Expand Up @@ -689,7 +689,7 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
continue;
}

final participant = _getOrCreateRemoteParticipant(info.identity, info);
final participant = await _getOrCreateRemoteParticipant(info.identity, info);

if (isNew) {
hasChanged = true;
Expand Down
22 changes: 11 additions & 11 deletions lib/src/participant/remote.dart
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,18 @@ class RemoteParticipant extends Participant<RemoteTrackPublication> {
name: name,
);

@internal
RemoteParticipant.fromInfo({
static Future<RemoteParticipant> createFromInfo({
required Room room,
required lk_models.ParticipantInfo info,
}) : super(
room: room,
sid: info.sid,
identity: info.identity,
name: info.name,
) {
updateFromInfo(info);
}) async {
final participant = RemoteParticipant(
room: room,
sid: info.identity,
identity: info.identity,
name: info.name,
);
await participant.updateFromInfo(info);
return participant;
}

/// A convenience property to get all video tracks.
Expand Down Expand Up @@ -192,8 +193,7 @@ class RemoteParticipant extends Participant<RemoteTrackPublication> {
final newPubs = <RemoteTrackPublication>{};

for (final trackInfo in info.tracks) {
final RemoteTrackPublication? pub =
getTrackPublicationBySid(trackInfo.sid);
final RemoteTrackPublication? pub = getTrackPublicationBySid(trackInfo.sid);
if (pub == null) {
final RemoteTrackPublication pub;
if (trackInfo.type == lk_models.TrackType.VIDEO) {
Expand Down
Loading