event logging #925
Merged
event logging #925
+236
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a log statement at Level.FINEST in the EventsEmitter<T>.emit method to provide detailed tracing when emitting events. This helps with debugging and monitoring event emissions when fine-grained logging is enabled.
Changed the log level from FINE to FINEST for more detailed debugging and updated the log output to include the log level name for better clarity.
Implemented or updated toString() methods for all event classes in lib/src/events.dart and lib/src/internal/events.dart to provide more informative and structured textual representations for logging and debugging. This improves traceability and clarity when inspecting event objects.
Moved base event mixins (LiveKitEvent, RoomEvent, etc.) from events.dart to a new events_base.dart to avoid import cycles and added an isInternal property for distinguishing internal events. Updated internal/events.dart and event emitters to use the new base, and improved logging to indicate event scope.
Documented the addition of trace-level event logging with internal/public tagging and updated example app logging to FINEST in the changes log.
Updated the toString methods in RoomDisconnectedEvent and RoomRecordingStatusChanged to use a more descriptive format with named parameters for better readability and debugging.
Added InternalEvent mixin to TrackEndedEvent and formatted its toString method for consistency.
Simplified the change description in the event-logging-trace file to focus on public/internal tagging for event logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.