Skip to content

Expose RPC types #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

Expose RPC types #575

merged 1 commit into from
Feb 4, 2025

Conversation

@hiroshihorie
Copy link
Member

No description provided.

@hiroshihorie hiroshihorie requested a review from bcherry February 4, 2025 06:47
bcherry
bcherry approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this! I'm really not sure how my tests worked at all...

@hiroshihorie
Copy link
Member Author

@bcherry Could you take a quick look if exposing these are sufficient ? 🙏

bcherry
bcherry approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this seems to work

@hiroshihorie hiroshihorie merged commit 12a6a4d into main Feb 4, 2025
12 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/expose-rpc-types branch February 4, 2025 20:59
@natecraft1
Copy link

thank you for fixing this! I'm really not sure how my tests worked at all...

I think it's because you have @testable import LiveKit in the tests which exposes all the internal types. I wonder if removing @testable would have prevented the test from compiling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcherry bcherry bcherry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hiroshihorie @natecraft1 @bcherry