Skip to content

Conversation

@ladvoc
Copy link
Contributor

@ladvoc ladvoc commented Feb 14, 2025

Summary of changes:

  • Fix Cocoapods: create private spec repo for dependencies which no longer support Cocoapods.
  • Update documentation: instructions for adding LiveKit source.
  • Create workflows to lint podspec and automatically push to trunk on new release.

Note: COCOAPODS_TRUNK_TOKEN must be set in the repository’s secrets before using the push workflow.

- Explicit setup of Xcode and CocoaPods
- Upload validation directory on failure
@ladvoc ladvoc changed the title CocoaPods Workflows CocoaPods workflows Feb 14, 2025
@hiroshihorie
Copy link
Member

Unfortunately we might need to replace Swift-Log if we want to continue to support Cocoapods :

- ERROR | [visionOS] unknown: Encountered an unknown error (The platform of the target `App` (visionOS 1.0) is not compatible with `Logging (1.4.0)`, which does not support `visionOS`.

apple/swift-log#271

@ladvoc
Copy link
Contributor Author

ladvoc commented Feb 28, 2025

The issue stems from the fact that Cocoapods is no longer officially supported for swift-log. As a result, the Podspec for swift-log hasn’t been updated since the release of VisionOS, and when we recently added VisionOS as a supported target in our Podspec (#587), this introduced an error. Short of dropping support for Cocoapods or replacing swift-log, a potential solution is to build swift-log as a binary XCFramework which Cocoapods can depend on.

@ladvoc ladvoc changed the title CocoaPods workflows CocoaPods fix Mar 3, 2025
@ladvoc ladvoc requested a review from hiroshihorie March 4, 2025 20:10
Comment on lines -11 to -12
spec.tvos.deployment_target = "17.0"
spec.visionos.deployment_target = "1.0"

This comment was marked as resolved.

@ladvoc ladvoc merged commit b435c73 into livekit:main Mar 7, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants