Skip to content

Simplify video buffer capturing #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 3, 2025
Merged

Simplify video buffer capturing #611

merged 10 commits into from
Mar 3, 2025

Conversation

@hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Feb 28, 2025 •
edited
Loading

  • Move logic from LKRTCVideoCapturerDelegate to VideoCapturer.
  • Add video codec tests.

@ilo-nanpa
Copy link

ilo-nanpa bot commented Feb 28, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@hiroshihorie hiroshihorie changed the title Codec detector Tests: Video codec Feb 28, 2025
@hiroshihorie hiroshihorie marked this pull request as ready for review February 28, 2025 18:38
@hiroshihorie hiroshihorie requested a review from ladvoc February 28, 2025 18:39
@hiroshihorie hiroshihorie changed the title Tests: Video codec Simplify video buffer capturing Mar 3, 2025
@hiroshihorie hiroshihorie merged commit b7c2ebc into main Mar 3, 2025
13 of 16 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/test-video-codec branch March 3, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ladvoc ladvoc ladvoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiroshihorie @ladvoc