Skip to content

Conversation

@hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Oct 12, 2025

  • Added @available(iOSApplicationExtension, unavailable) to fix compile issues when building app extension.
  • Reorganized the setXXX APIs so I can mark setCamera(enabled:) unavailable in the extension.
    This PR should be non-breaking.

Not sure if these changes are required even after using lib with webrtc-sdk/webrtc#202

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

⚠️ This PR does not contain any files in the .changes directory.

Copy link
Contributor

@pblazej pblazej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can avoid marking our own APIs (for now) vs guessing what should be marked.

@hiroshihorie hiroshihorie merged commit 4e94136 into main Oct 17, 2025
22 of 28 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/fix-extension-build branch October 17, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants