Skip to content

Conversation

@pblazej
Copy link
Contributor

@pblazej pblazej commented Nov 24, 2025

Resolves #843

  • Reverts the core part of Camera format selection logic #833 for multi cam devices, as it may cause timeout when mixing wrong format vs session type
  • Adds aspectRatio criterion to minimize cropping
  • Fixes VideoView jumps when using square formats in fill mode due to floating point comparisons (flipping between 1+/-eps)

Waiting for a better fix for square cropping (if any).

image

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

⚠️ This PR does not contain any files in the .changes directory.

@pblazej pblazej force-pushed the blaze/multicam-fixes branch from 266e22b to 7f5b061 Compare November 24, 2025 11:33
@pblazej pblazej force-pushed the blaze/multicam-fixes branch from 7f5b061 to 1873dcb Compare November 24, 2025 11:33
@pblazej pblazej marked this pull request as ready for review November 25, 2025 08:39
@pblazej pblazej requested a review from hiroshihorie November 25, 2025 11:01
Copy link
Member

@hiroshihorie hiroshihorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pblazej pblazej merged commit d94c575 into main Nov 25, 2025
27 of 28 checks passed
@pblazej pblazej deleted the blaze/multicam-fixes branch November 25, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS: Video publish times out waiting for dimensions (Code 101) on iPhone 13 Pro Max (audio ok, AVFoundation works)

3 participants