Skip to content

fix(core): dedupe transcriptions based on segment id #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

fix(core): dedupe transcriptions based on segment id #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f3e7e
fix(core): dedupe transcriptions based on segment id
lukasIO May 22, 2025
4a81670
Create popular-mugs-drive.md
lukasIO May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-mugs-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/components-core": patch
---

fix(core): dedupe transcriptions based on segment id
7 changes: 6 additions & 1 deletion packages/core/src/components/textStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ export function setupTextStream(room: Room, topic: string): Observable<TextStrea
// Subscribe to the stream and update our array when new chunks arrive
streamObservable.subscribe((accumulatedText) => {
// Find and update the stream in our array
const index = textStreams.findIndex((stream) => stream.streamInfo.id === reader.info.id);
const index = textStreams.findIndex(
(stream) =>
stream.streamInfo.id === reader.info.id ||
stream.streamInfo.attributes?.['lk.segment_id'] ===
reader.info.attributes?.['lk.segment_id'],
);
if (index !== -1) {
textStreams[index] = {
...textStreams[index],
Expand Down