Reduce threshold of out-of-order very old packet detection.#2951
Merged
Conversation
There are cases where the very first packet on resume is an out-of-order packet. In that case, the gap in both sequence number and time stamp is a small(ish) negative number. With a high threshold to declare very old packet, the condition does not trip and the packet gets through and treated as a packet that has rolled over. It should be fine to have smaller threshold (in fact, it is probably okay to have something a little over 1.0 too) as the expected jump is calculated based on elapsed time since last packet receive and new packets should be coming in with a diff close to that. So, a factor of just over 1.0 to prevent false triggers should be fine. Using 1.5 for now.
Contributor
Author
Thought about it. But, a very edge case. So, decided to skip it. Will make one if I have to mess with this again. |
boks1971
added a commit
that referenced
this pull request
Aug 22, 2024
There are cases where the very first packet on resume is an out-of-order packet. In that case, the gap in both sequence number and time stamp is a small(ish) negative number. With a high threshold to declare very old packet, the condition does not trip and the packet gets through and treated as a packet that has rolled over. It should be fine to have smaller threshold (in fact, it is probably okay to have something a little over 1.0 too) as the expected jump is calculated based on elapsed time since last packet receive and new packets should be coming in with a diff close to that. So, a factor of just over 1.0 to prevent false triggers should be fine. Using 1.5 for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where the very first packet on resume is an out-of-order packet. In that case, the gap in both sequence number and time stamp is a small(ish) negative number. With a high threshold to declare very old packet, the condition does not trip and the packet gets through and treated as a packet that has rolled over.
It should be fine to have smaller threshold (in fact, it is probably okay to have something a little over 1.0 too) as the expected jump is calculated based on elapsed time since last packet receive and new packets should be coming in with a diff close to that. So, a factor of just over 1.0 to prevent false triggers should be fine. Using 1.5 for now.