Use RequestResponse to report protocol handling errors#3895
Merged
Use RequestResponse to report protocol handling errors#3895
RequestResponse to report protocol handling errors#3895Conversation
boks1971
commented
Sep 2, 2025
| } | ||
|
|
||
| func (c ClientInfo) SupportPrflxOverRelay() bool { | ||
| func (c ClientInfo) SupportsPrflxOverRelay() bool { |
Contributor
Author
There was a problem hiding this comment.
Just making these naming consistent using the prefix Supports
cnderrauber
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol PR - livekit/protocol#1184
Send responses for protocol handling errors.
For specific signal requests
offer- will error out and force a negotiation error if something goes wrong, so noRequestResponsesent.answer- same as abovetrickle- added sending error response in this PR.add_track- added sending error response in this PR (including aQUEUEDindication when the request is queued)mute- added sending error response in this PRsubscription- TODOtrack_setting- TODOleave- this will close the participant and it could sendLeaveRequestback, so noRequestResponsesent.SetSimulcastLayers- deprecated and not included in livekit_rtc.proto fileupdate_layers- deprecated (might come back at some point)subscription_permission- TODOsync_state- errors in this will trigger a full reconnect, so noRequestResponsesent.simulate- not planningRequestResponse.ping- deprecatedupdate_metadata- already hadRequestResponse, this PR enhances the response.ping_req- this is already a ping/pong, so noRequestResponse.update_audio_track- this PR addsRequestResponse.update_video_track- same as above.