Potential fix for code scanning alert no. 35: Workflow does not contain permissions#4311
Merged
biglittlebigben merged 1 commit intomasterfrom Feb 10, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
matkam
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/livekit/livekit/security/code-scanning/35
In general, the fix is to declare an explicit
permissions:block either at the workflow root or for the specific job, limitingGITHUB_TOKENto the minimal scopes needed. For a build-and-push-to-Docker workflow like this, the only GitHub interaction is checking out the code, which needscontents: read. All DockerHub interactions usesecrets.DOCKERHUB_*and do not requireGITHUB_TOKENwrite access.The best minimal fix without changing functionality is to add a root-level
permissions:block after thename:(or underon:) that setscontents: read. This will apply to all jobs (currently onlydocker) unless overridden. No steps need write access to repository contents, issues, or pull requests, and no extra scopes are required, socontents: readis sufficient. Concretely, in.github/workflows/docker.yaml, add:at the top workflow level (e.g., between
name: Release to Dockerandon:). No imports or further definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.