Do not close publisher peer connection to aid migration.#4427
Merged
Do not close publisher peer connection to aid migration.#4427
Conversation
Partial revert of #4382. Closing publisher peer connection unpublishes the published track and the cross check between sync state and migrator state causes migration to be aborted if it happens to be delayed. This change does mean, this code path cannot be used in single peer connection mode. Have to think about if the cross-check is really necessary.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paulwe
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #4382.
Closing publisher peer connection unpublishes the published track and the cross check between sync state and migrator state causes migration to be aborted if it happens to be delayed. This change does mean, this code path cannot be used in single peer connection mode. Have to think about if the cross-check is really necessary.