Document mono package, support Unix and Parse. #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to clarify usage of the
monopackage. The change adds some basic docs as well as some extra API and deprecations.A few proposed changes:
time.Now()is fine, there's no need to usemono.Now(). Go's time is already monotonic.time.Now()directly inmono.Now(). There shouldn't be a need for getting relative time from the reference.mono.FromTime. Introducemono.Unix(sec,ns)andmono.Parseinstead. Most non-monotonic timestamps come from these two functions.In addition, we should probably add a static check to CI for core and media repos to catch remaining usages of
time.Unixandtime.Parse. These must be updated to correspondingmonofunction calls. This should be easier than tracking down all non-monotonic timestamps across the codebase.