-
Notifications
You must be signed in to change notification settings - Fork 113
Egress stream retry info #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egress stream retry info #1293
Conversation
|
|
How is this communicated to the client? Through a webhook? |
Yes - that's correct - through web hook |
protobufs/livekit_egress.proto
Outdated
| int64 last_retry_at = 7; | ||
| int64 retries = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe timestamp for last_retry_at and uint for retries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought about it - chose int64 for retry_at to be consistent with started_at and ended_at.
retries could be uint though
|
Hm - there is a conflict in the autogenerated code - the cleanest way to resolve this would be opening a new PR (not wise to fiddle with autogenerated code) |
When egress uses RTMP streams as outputs - it could happen that a remote RTMP server (or something in between) closes connection. Egress is auto retrying already started recordings but frequent retries could cause multiple video files being recorded on the remote (vendor side - we had a specific case of too many small youtube videos being created)
The suggested protocol update would enable us to communicate when this happens so that publishing side could take some action if needed.