Skip to content

Conversation

@alexlivekit
Copy link
Contributor

@alexlivekit alexlivekit commented Nov 13, 2025

The only things changed here, Ignoring automatic protoc version bump by GHA, are:

  • protobufs/livekit_sip.proto : Added more SIP codes to enum.
  • livekit/sip.go : Changed to explicit SIPStatusCode-to-codes.Code map.
  • livekit/sip_test.go : Modified test to expect the updated status.

@alexlivekit alexlivekit requested a review from a team November 13, 2025 21:35
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: aad452f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

SIPStatusCode_SIP_STATUS_REQUEST_TIMEOUT: codes.DeadlineExceeded,
SIPStatusCode_SIP_STATUS_CONFLICT: codes.FailedPrecondition,
SIPStatusCode_SIP_STATUS_GONE: codes.NotFound,
SIPStatusCode_SIP_STATUS_LENGTH_REQUIRED: codes.InvalidArgument,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you, but we could potentially remove most of the 4xx mappings in favour of a default that we already have (it's InvalidArgument by default). Could probably keep the most frequent ones in the map and let everything else fall back to a default. But I don't mind if we keep the map as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like there to be one source of "What does X turn to", and the fallback being a purely unexpected/unimplemented safety net. Easier to debug imo.

Co-authored-by: Denys Smirnov <denys@livekit.io>
@alexlivekit alexlivekit merged commit 16b9a98 into main Nov 14, 2025
8 checks passed
@alexlivekit alexlivekit deleted the sip-errors branch November 14, 2025 18:29
This was referenced Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants