-
Notifications
You must be signed in to change notification settings - Fork 113
Sip to grpc error code mapping update #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: aad452f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
| SIPStatusCode_SIP_STATUS_REQUEST_TIMEOUT: codes.DeadlineExceeded, | ||
| SIPStatusCode_SIP_STATUS_CONFLICT: codes.FailedPrecondition, | ||
| SIPStatusCode_SIP_STATUS_GONE: codes.NotFound, | ||
| SIPStatusCode_SIP_STATUS_LENGTH_REQUIRED: codes.InvalidArgument, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you, but we could potentially remove most of the 4xx mappings in favour of a default that we already have (it's InvalidArgument by default). Could probably keep the most frequent ones in the map and let everything else fall back to a default. But I don't mind if we keep the map as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like there to be one source of "What does X turn to", and the fallback being a purely unexpected/unimplemented safety net. Easier to debug imo.
Co-authored-by: Denys Smirnov <denys@livekit.io>
The only things changed here, Ignoring automatic protoc version bump by GHA, are:
SIPStatusCode-to-codes.Codemap.