Skip to content

add missing proto import #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
+14 −17
Merged

add missing proto import #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9fb810
add missing proto import
paulwe Nov 20, 2025
a85faa8
generated protobuf
github-actions[bot] Nov 20, 2025
3ed372f
Create mighty-ants-whisper.md
paulwe Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-ants-whisper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/protocol": patch
---

add missing proto import
6 changes: 3 additions & 3 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,7 @@ message ParticipantInfo {
int64 joined_at = 6;
// timestamp when participant joined room, in milliseconds
int64 joined_at_ms = 17;
string name = 9 [
(logger.redact) = true,
(logger.redact_format) = "<redacted ({{ .Size }} bytes)>"
];
string name = 9 [(logger.redact) = true];
uint32 version = 10;
ParticipantPermission permission = 11;
string region = 12;
Expand Down Expand Up @@ -233,9 +230,7 @@ message SimulcastCodecInfo {
message TrackInfo {
string sid = 1;
TrackType type = 2;
string name = 3 [
(logger.redact) = true
];
string name = 3 [(logger.redact) = true];
bool muted = 4;
// original width of video (unset for audio)
// clients may receive a lower resolution version with simulcast
Expand Down
6 changes: 3 additions & 3 deletions rpc/typed_api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ func TestMiddleware(t *testing.T) {
}

for _, c := range cases {
var o psrpc.ClientOpts
c.opt(&o)
t.Run(c.label, func(t *testing.T) {
var o psrpc.ClientOpts
c.opt(&o)
for _, c := range o.RpcInterceptors {
ch := make(chan []psrpc.RequestOption, 1)
call := c(psrpc.RPCInfo{}, func(ctx context.Context, req proto.Message, opts ...psrpc.RequestOption) (proto.Message, error) {
Expand All @@ -45,7 +45,7 @@ func TestMiddleware(t *testing.T) {
expected := []psrpc.RequestOption{func(*psrpc.RequestOpts) {}, func(*psrpc.RequestOpts) {}}
go call(context.Background(), nil, expected...)

eqPtr := func(a psrpc.RequestOption) func(a psrpc.RequestOption) bool {
eqPtr := func(a psrpc.RequestOption) func(psrpc.RequestOption) bool {
return func(b psrpc.RequestOption) bool {
return reflect.ValueOf(a).Pointer() == reflect.ValueOf(b).Pointer()
}
Expand Down
5 changes: 1 addition & 4 deletions utils/math.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,5 @@ func FastLogisticFunc(x0, L, k float64) func(x float64) float64 {
}

func Abs[T constraints.Signed | constraints.Float](v T) T {
if v < 0 {
return -v
}
return v
return max(v, -v)
}
Loading