Improve logging for media #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dennwc
commented
Oct 10, 2025
dennwc
commented
- Log media timeout resets.
- Add media timeout tests.
- Print call stats (including media) regularly.
- Track closed states for the call components.
nishadmusthafa
approved these changes
Oct 10, 2025
|
|
||
| // Ticker is allowed to fire earlier than the full timeout interval. Skip if it's not a full timeout yet. | ||
| if since < timeout { | ||
| if since+timeout/10 < timeout { |
Contributor
There was a problem hiding this comment.
why are we doing this ?
Contributor
Author
There was a problem hiding this comment.
Tests were detecting a timeout that triggers too late. It was off by a few ms, hence this change. Not a big deal if we trigger it later (as it is right now), but this makes tests a bit cleaner.
Contributor
There was a problem hiding this comment.
Tests were detecting a timeout that triggers too late.
Is this dues to go scheduling? What's the average wake delay we're working with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.