Commit 4ca0773
fix: address PR #327 round-4 review (doc comments only)
PR #327 round 4 — two one-line documentation hardenings + targeted
declines:
- e2e/topic_acl_error_envelope_v14_test.go:
* Add grep-anchor comment pointing at livetemplate's mount.go WARN
string the keep-open assertion couples to (substring match would
silently no-op if the WARN is reworded; the anchor makes the
coupling explicit for the Phase-5 owner). Note structured-attribute
hardening as a future Phase 5/6 option. (Claude PR #327 round-4 #2.)
* Add explicit 'Not parallel: this test mutates the process-global
slog.Default' comment at the top of the test function. (Claude
PR #327 round-4 #5.)
Items declined / acknowledged (see PR reply):
- #1 (Makefile guard / pre-commit sentinel for go.mod replace):
defensive add-on; the existing inline warning + PR body + DRAFT label
are already 3 layers of warning. Phase 5 resolves the replace
entirely, removing the failure mode permanently.
- #3 (poll() time.Sleep busy-wait): Claude framed as 'worth noting for
Phase 5/6, not a blocker'; same as round 3 #1 — defer to Phase 5/6.
- #4 (io.MultiWriter to stderr is noisy in CI): intentional pattern,
matches lifecycle_ergonomics_test.go; dev-time live tailing
visibility outweighs CI noise on a passing test, and dump() still
surfaces the captured stream on failure.
- #6 (Ping uses blank identifier for ctx): Claude confirms intentional
for test fixture — no action.
Verified: GOWORK=off go test -tags=browser -v -timeout=5m \
-run TestE2E_V14_TopicACLDeniedEmitsLvtErrorAndKeepsWSOpen ./e2e/
PASS (1.54s).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent a9e2a54 commit 4ca0773
1 file changed
Lines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
181 | 187 | | |
182 | 188 | | |
183 | 189 | | |
| |||
265 | 271 | | |
266 | 272 | | |
267 | 273 | | |
268 | | - | |
269 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
270 | 283 | | |
271 | 284 | | |
272 | 285 | | |
| |||
0 commit comments