Skip to content

feat(highlighting): Can display textrange-based highlights #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 24, 2019
Merged

feat(highlighting): Can display textrange-based highlights #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
18d4231
feat(highlighting): Can display textrange-based highlights
lukasbuenger Feb 27, 2019
27d1905
test: test text range highlighting
lukasbuenger Feb 28, 2019
423cd8a
refactor: expose rangy/TextRange as part of editable selection
lukasbuenger Mar 4, 2019
99dffb9
refactor: introduce highlight span range extraction
lukasbuenger Mar 4, 2019
26ec895
test: highlight position extraction
lukasbuenger Mar 5, 2019
0f7e151
refactor: use a blank range to calculate text ranges
lukasbuenger Mar 7, 2019
1831748
refactor: skip and warn when passed a cursor
lukasbuenger Mar 7, 2019
6838b9e
refactor: respect newlines and upsert
lukasbuenger Mar 7, 2019
be93cd6
refactor: wip, extend use case catalogue
lukasbuenger Mar 7, 2019
b1cfdbd
refactor: export rangy text range as method
lukasbuenger Mar 7, 2019
38037db
refactor: move anonymous import to top
lukasbuenger Mar 7, 2019
6dcd9eb
test: make full example test the complete roundtrip
lukasbuenger Mar 8, 2019
22c6a08
test: test with extracted ranges
lukasbuenger Mar 8, 2019
796408d
fix: Selection.getTextRange respects newlines
lukasbuenger Mar 8, 2019
47dee17
refactor: use the text range module to extract and wrap highlight con…
lukasbuenger Mar 8, 2019
6525224
refactor: selection returns simple text range again
lukasbuenger Mar 8, 2019
4d7efc5
test: request 'natural' offsets
lukasbuenger Mar 8, 2019
9f5ee6b
fix: hound-cli error. remove unused fake match
lukasbuenger Mar 8, 2019
a95e4c5
fix: disable spellcheck sanitation
lukasbuenger Mar 27, 2019
f1d3535
fix: highlights get only applied to editableHost
lukasbuenger Mar 27, 2019
1df1071
chore: mark range props as required in doc block
lukasbuenger Apr 18, 2019
6727130
refactor: remove unused argumen
lukasbuenger Apr 18, 2019
0cd0e93
test: test text extraction based on extracted ranges as well
lukasbuenger Apr 18, 2019
62b18d6
feat: export the range text on the extracted range object
lukasbuenger Apr 18, 2019
d2ef3eb
refactor: check for data-highlight value when deciding about highligh…
lukasbuenger Apr 20, 2019
09e0bdb
fix: cleanup empty highlights
lukasbuenger Apr 20, 2019
ef8b3f7
test: html output
lukasbuenger Apr 20, 2019
a010e9b
test: special chars
lukasbuenger Apr 20, 2019
cf60696
chore: rm package-lock.json, accidentially added.
lukasbuenger Apr 20, 2019
57387a4
test: small unit-tests for special chars in ranges
lukasbuenger Apr 24, 2019
8541e62
test: check highlighting intersecting format tags
lukasbuenger Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading