Skip to content

Commit e98aab8

Browse files
committed
fix: simplify get-release-note (we have no release branches anymore)
1 parent 3447181 commit e98aab8

3 files changed

Lines changed: 6 additions & 31 deletions

File tree

index.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,7 @@ module.exports = async ({token, owner, repo, sha, tag, test = false} = {}) => {
3030

3131
// 'content/operations/releases/release-2021-03.md'
3232
const path = `${targetBasePath}/${release.branchName}.md`
33-
const {releaseNote, branchName} = await getReleaseNote({
34-
owner: targetOwner,
35-
repo: targetRepo,
36-
path,
37-
token,
38-
releaseName: release.branchName
39-
})
33+
const releaseNote = await getReleaseNote({owner: targetOwner, repo: targetRepo, path, token})
4034

4135
// base64 to string
4236
const originReleaseNote = Buffer.from(releaseNote.content, 'base64').toString('utf8')

lib/get-release-note.js

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,16 @@
11
const getContent = require('./git/get-content')
22

3-
module.exports = async ({owner, repo, path, token, releaseName}) => {
4-
let releaseNote
3+
module.exports = async ({owner, repo, path, token}) => {
54
try {
6-
releaseNote = await getContent({
5+
return await getContent({
76
owner,
87
repo,
98
token,
109
path,
1110
branch: 'master'
1211
})
13-
return {releaseNote, branchName: 'master'}
1412
} catch (error) {
15-
try {
16-
releaseNote = await getContent({
17-
owner,
18-
repo,
19-
token,
20-
path,
21-
branch: releaseName
22-
})
23-
return {releaseNote, branchName: releaseName}
24-
} catch (err) {
25-
console.log(err)
26-
throw new Error(`get-release-note: https://github.com/${owner}/${repo}/${path} not found.`)
27-
}
13+
console.log(err)
14+
throw new Error(`get-release-note: https://github.com/${owner}/${repo}/${path} not found.`)
2815
}
2916
}

patch-release-notes-overview.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@ const targetRepo = 'documentation'
55

66
module.exports = async ({token, owner, repo, sha, tag, test = false, release} = {}) => {
77
const path = `data/releases.json`
8-
const {releaseNote, branchName} = await getReleaseNote({
9-
owner: targetOwner,
10-
repo: targetRepo,
11-
path,
12-
token,
13-
releaseName: release.branchName
14-
})
8+
const releaseNote = await getReleaseNote({owner: targetOwner, repo: targetRepo, path, token})
159

1610
// base64 to string
1711
const originContent = JSON.parse(Buffer.from(releaseNote.content, 'base64').toString('utf8'))

0 commit comments

Comments
 (0)