Skip to content

Conversation

@ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Feb 3, 2025

What does this PR do?

Updates AgentConfig to support llamastack/llama-stack#938

  • Addresses issue (#issue)

Test Plan

Tested in llamastack/llama-stack#938

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

# What does this PR do?

Updates AgentConfig to support llamastack/llama-stack#938

- [ ] Addresses issue (#issue)


## Test Plan

Tested in llamastack/llama-stack#938

## Sources

Please link relevant resources if necessary.


## Before submitting

- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Ran pre-commit to handle lint / formatting issues.
- [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md),
      Pull Request section?
- [ ] Updated relevant documentation.
- [ ] Wrote necessary unit or integration tests.
Copy link
Contributor

@yanxi0830 yanxi0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline, these changes need to be generated. Should we also update the example agent scripts in llama-stack-apps repo?

@ehhuang
Copy link
Contributor Author

ehhuang commented Feb 6, 2025

synced change in #126

@ehhuang ehhuang closed this Feb 6, 2025
@ashwinb ashwinb deleted the pr119 branch August 14, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants