refactor(field_mutator): migrate dot notation to JSON Pointer syntax #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
approved these changes
Jul 18, 2025
…SON Pointer syntax Signed-off-by: Matthew F Leader <mleader@redhat.com>
mfleader
force-pushed
the
field-mutator-jsonpointer
branch
from
0f301a2 to
bba1dfd
Compare
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Jul 18, 2025
…lamastack#118) Replaces custom dot notation parser with [RFC 6901 JSON Pointer](https://datatracker.ietf.org/doc/html/rfc6901) syntax to handle Kubernetes label keys containing dots (e.g., `app.kubernetes.io/instance`). Migration enables proper Service selector transformations where previous dot notation failed on keys like `spec.selector["app.kubernetes.io/instance"]`, unblocking dynamic Service-to-Deployment label matching. Approved-by: leseb Approved-by: rhdedgar (cherry picked from commit e42489a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces custom dot notation parser with RFC 6901 JSON Pointer syntax to handle Kubernetes label keys containing dots (e.g.,
app.kubernetes.io/instance).Migration enables proper Service selector transformations where previous dot notation failed on keys like
spec.selector["app.kubernetes.io/instance"], unblocking dynamic Service-to-Deployment label matching.