refactor(controller): delegate health checks to k8s readiness probes #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfleader
force-pushed
the
readiness-probe
branch
from
5ae3bdb to
1f00af9
Compare
There was a problem hiding this comment.
LGTM as a layman, but I'll leave the final approval to @VaishnaviHire 😄
Thanks for this @mfleader!
rhdedgar
reviewed
Jul 30, 2025
mfleader
force-pushed
the
readiness-probe
branch
from
6f12141 to
3deaca9
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
…dependency injection (#133) Refactors the LlamaStackDistributionReconciler to accept an httpClient dependency. This makes the controller's status-update logic, which relies on external API calls, testable in isolation. The primary goal of this change is to enable a new integration test that validates the controller correctly populates provider and version info in the resource status. This test is added to formalize the expected behavior and prevent regressions. `checkHealth()` and its endpoint `v1/health` were not included in these changes since they will be removed in a subsequent code change, [130](#130). Approved-by: rhdedgar
mfleader
force-pushed
the
readiness-probe
branch
from
8a99a83 to
61e42c5
Compare
|
Untested but code lgtm |
derekhiggins
approved these changes
Aug 12, 2025
What about the test in |
I mean't it was untested by me (i.e. I didn't run the code locally) |
The controller now relies on the Deployment's readiness status, which is driven by a new readiness probe on the container. This removes the operator's redundant, manual health-checking logic and makes the system more robust by using a standard Kubernetes feature. Signed-off-by: Matthew F Leader <mleader@redhat.com>
Signed-off-by: Matthew F Leader <mleader@redhat.com>
mfleader
force-pushed
the
readiness-probe
branch
from
5c09fcd to
9c23a53
Compare
mfleader
requested review from
VaishnaviHire,
nathan-weinberg and
rhdedgar
and removed request for
rhdedgar
mfleader
requested review from
rhdedgar
and removed request for
VaishnaviHire,
nathan-weinberg and
rhdedgar
rhdedgar
approved these changes
Aug 14, 2025
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Aug 19, 2025
…dependency injection (llamastack#133) Refactors the LlamaStackDistributionReconciler to accept an httpClient dependency. This makes the controller's status-update logic, which relies on external API calls, testable in isolation. The primary goal of this change is to enable a new integration test that validates the controller correctly populates provider and version info in the resource status. This test is added to formalize the expected behavior and prevent regressions. `checkHealth()` and its endpoint `v1/health` were not included in these changes since they will be removed in a subsequent code change, [130](llamastack#130). Approved-by: rhdedgar (cherry picked from commit 7cca6e4)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Aug 19, 2025
…lamastack#130) The controller now relies on the Deployment's readiness status, which is driven by a new readiness probe on the container. This removes the operator's redundant, manual health-checking logic and makes the system more robust by using a standard Kubernetes feature. Approved-by: rhdedgar (cherry picked from commit 2fa21ea)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…dependency injection (llamastack#133) Refactors the LlamaStackDistributionReconciler to accept an httpClient dependency. This makes the controller's status-update logic, which relies on external API calls, testable in isolation. The primary goal of this change is to enable a new integration test that validates the controller correctly populates provider and version info in the resource status. This test is added to formalize the expected behavior and prevent regressions. `checkHealth()` and its endpoint `v1/health` were not included in these changes since they will be removed in a subsequent code change, [130](llamastack#130). Approved-by: rhdedgar (cherry picked from commit 7cca6e4)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…lamastack#130) The controller now relies on the Deployment's readiness status, which is driven by a new readiness probe on the container. This removes the operator's redundant, manual health-checking logic and makes the system more robust by using a standard Kubernetes feature. Approved-by: rhdedgar (cherry picked from commit 2fa21ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller now relies on the Deployment's readiness status, which is driven by a new readiness probe on the container.
This removes the operator's redundant, manual health-checking logic and makes the system more robust by using a standard Kubernetes feature.