feat: Add version checking for controller-gen tool #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuss
added a commit
to rhuss/llama-stack-k8s-operator
that referenced
this pull request
May 9, 2025
Updates to operator-sdk v1.39.2 and aligns the Makefiles for better consistency. It supersedes PR llamastack#20 which updated the makefile and controller-gen target. Added a new 'pre-commit' makefile target to run pre-commit hooks on all files.
rhuss
added a commit
to rhuss/llama-stack-k8s-operator
that referenced
this pull request
May 9, 2025
Updates to operator-sdk v1.39.2 and aligns the Makefiles for better consistency. It supersedes PR llamastack#20 which updated the makefile and controller-gen target. Added a new 'pre-commit' makefile target to run pre-commit hooks on all files.
VaishnaviHire
pushed a commit
that referenced
this pull request
May 12, 2025
Updates to operator-sdk v1.39.2 and aligns the Makefiles for better consistency with operator-sdk generated Makefile. It supersedes #20, and allows for a more elegant way for installing tools locally (like its done nowadays in the operator-sdk generated Makefiles). Also aligned versions with the versions that operator-sdk v1.39.2 is using. Changes include: - Update operator-sdk to v1.39.2 - Align Makefile with latest operator-sdk scaffold - Improve tool dependency management - Add pre-commit makefile target - Update dependencies in go.mod - Refactor install procedures for tools Note: Due to the way how tools are downloaded now, it's recommended to remove `bin/` to remove legacy tools.
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Jul 18, 2025
[odh] Sync upstream + add 2.23 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Version Checking for controller-gen Tool
Description
This PR enhances the Makefile by adding version checking for the controller-gen tool. Previously, the Makefile only checked if controller-gen was installed, but didn't verify if the installed version matched the version specified in
CONTROLLER_TOOLS_VERSION. This could lead to subtle build issues if the wrong version was being used.Motivation for this PR was that I had strange recommit issues because I had a local
codegenbinary inbinthat was 0.17.2, but Makefile references 0.17.3. It didn't get reinstalled, but the GitHub action always installs it afresh (0.17.3) and therefor some differences in the generated manifest were detected.Changes
Testing
Tested by: